Changeset 195 for vtcross/trunk/src/lib

Timestamp:

03/23/09 21:38:08 (15 years ago)

Author:

bhilburn

Message:

CE_Info didn't make sense anymore since it was really describing the
entire radio; fixed.

Files:

• vtcross/trunk/src/lib/socketcomm/socketcomm.cpp (modified) (5 diffs)

vtcross/trunk/src/lib/socketcomm/socketcomm.cpp

@@ -28 +28 @@
 // TODO can someone write a description of how this function is operating? I'm
 // not sure I understand why it is making two separate blocking calls to recv
+//
+// TODO also, it appears that this function can, at maximum, receive 256 bytes
+// without causing a buffer overflow. can someone confirm/deny?
 void
 ReadMessage(int32_t socketFD, char* msgBuffer)
@@ -123 +126 @@
 int32_t 
 GetParameter(int32_t socketFD, struct Parameter pList[], \
-        struct CE_Info *ce_info)
+        struct Radio_Info *radio_info)
 {
     char buffer[256];
@@ -129 +132 @@
 
     ReadMessage(socketFD, buffer);
-    ce_info->numParameters = atoi(buffer);
+    radio_info->numParameters = atoi(buffer);
     LOG("socket_comm::GetParameter - Number of parameters: %d\n", \
-            ce_info->numParameters);
-    
-    for(size_t i = 0; i < ce_info->numParameters; i++) {
+            radio_info->numParameters);
+    
+    for(size_t i = 0; i < radio_info->numParameters; i++) {
         memset(buffer, 0, 256);
         ReadMessage(socketFD, buffer);
@@ -172 +175 @@
 // instead of an entire 32 bit integer?  Seems wasteful.
 int32_t 
-GetRequest(int32_t socketFD, struct Parameter pList[], struct CE_Info *ce_info)
+GetRequest(int32_t socketFD, struct Parameter pList[], struct Radio_Info *radio_info)
 {
     char buffer[256];
@@ -185 +188 @@
 
     LOG("socket_comm::GetRequest - Getting parameters.\n\n");
-    GetParameter(socketFD, pList, ce_info);
+    GetParameter(socketFD, pList, radio_info);
 
     return 1;